Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Livechat guest pool based on department #7678

Conversation

vkislichenko
Copy link

@RocketChat/core

I've added call inquiry list and close methods,
exposed livechat iframe API
made inquiry to work based on current agent departments instead of listing online agents when room is created
also added one more status for inquiry to close it with the room

@RocketChat RocketChat deleted a comment Aug 7, 2017
@RocketChat RocketChat deleted a comment Aug 7, 2017
@RocketChat RocketChat deleted a comment Aug 7, 2017
@@ -716,6 +716,9 @@

// exports
w.RocketChat.livechat = {
// objects
api : api,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the api was intended to be the communication channel between rocket.chat instance and the livechat widget and not to be opened to the anyone.

@@ -32,9 +32,33 @@ <h3 title="{{username}}"><i class="status-{{status}}"></i> {{username}}</h3>
{{#if sms}} <li><i class="icon-mobile"></i>{{_ "SMS_Enabled"}}</li> {{/if}}
{{#if topic}} <li><strong>{{_ "Topic"}}</strong>: {{topic}}</li> {{/if}}
{{#if tags}} <li><strong>{{_ "Tags"}}</strong>: {{joinTags}}</li> {{/if}}
{{#if servedBy}}<li><strong>{{_ "Served by"}}</strong>: {{servedBy}}</li> {{/if}}
<li><strong>{{_ "ID"}}</strong>: {{_id}}</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the usage for the _id field?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When livechat is opened with same visitor twice, room _id can be used to discern two rooms apart

</ul>
</div>
{{/with}}

{{#with inquiry}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change to use tabs instead of spaces..

@@ -24,9 +25,18 @@ Template.visitorInfo.helpers({
},

room() {
console.log('room.id', this.rid);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops 😄

@sampaiodiego
Copy link
Member

@vkislichenko thank you for you contribution.. I'm sorry for the very late feedback, I was working on a very big pull request.

I've added a few comments already but I didn't have time to look at it all (I'm sorry for the partial review).. Please let me know you need any help.

rodrigok and others added 23 commits July 4, 2018 14:22
# Conflicts:
#	.docker/Dockerfile.rhel
#	.sandstorm/sandstorm-pkgdef.capnp
#	.travis/snap.sh
#	package.json
#	packages/rocketchat-lib/rocketchat.info
Merge master into develop & Set version to 0.67.0-develop
…hat#9991)

@RocketChat/core 

Closes RocketChat#9990

This pull request properly brings the web app manifest up-to-date to the current specification and resolves the incorrect start_url origin and the path to the broken images as seen in this screenshot.

This resolves the unwanted and incorrect behavior experienced in both Google Chrome and Mozilla Firefox for Android.

![image](https://user-images.githubusercontent.com/643503/36929663-052fe33c-1e49-11e8-8a68-3d8e666d30e8.png)
* Fix icons in channels message popup

* Fix descriptions in slash commands message popup

* Add scrolling in message popup
This pull request aims to format the SVG file containing the UI icons.

- [x] Fix indentation
- [x] Sort icons alphabetically by `id`
- [x] Recover icons lost in c1a5d57
vkislichenko and others added 24 commits August 29, 2018 18:48
…ool-based-on-department

# Conflicts:
#	package-lock.json
#	packages/rocketchat-livechat/client/views/app/tabbar/visitorInfo.js
#	packages/rocketchat-livechat/client/views/sideNav/livechat.js
#	packages/rocketchat-livechat/server/models/LivechatInquiry.js
#	packages/rocketchat-livechat/server/publications/livechatInquiries.js
Merge master into develop & Set version to 0.70.0-develop
@vkislichenko vkislichenko force-pushed the livechat-guest-pool-based-on-department branch from 32f2263 to c336b60 Compare September 7, 2018 15:06
@sampaiodiego
Copy link
Member

@renatobecker can you please take a look if this still makes sense?

@renatobecker-zz
Copy link

@renatobecker can you please take a look if this still makes sense?

Ok @sampaiodiego, I'm going to do it.

@renatobecker-zz
Copy link

@sampaiodiego, We support this approach already, we've made this implementation a few months ago:

https://github.com/RocketChat/Rocket.Chat/blob/develop/app/livechat/server/lib/QueueMethods.js#L117

We can close this issue I guess.

@sampaiodiego
Copy link
Member

thanks @renatobecker . closing then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet